Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cross Origin Policies headers DSL support #10141

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Add Cross Origin Policies headers DSL support #10141

merged 1 commit into from
Dec 7, 2021

Conversation

marcusdacoregio
Copy link
Contributor

Add DSL support for Cross-Origin-Opener-Policy, Cross-Origin-Embedder-Policy and Cross-Origin-Resource-Policy headers

Closes gh-9385, gh-10118

@marcusdacoregio marcusdacoregio added status: duplicate A duplicate of another issue in: config An issue in spring-security-config type: enhancement A general enhancement labels Jul 27, 2021
@marcusdacoregio marcusdacoregio self-assigned this Jul 27, 2021
@marcusdacoregio marcusdacoregio removed their assignment Jul 30, 2021
@marcusdacoregio marcusdacoregio modified the milestones: 6.x, 5.7.x Oct 22, 2021
@eleftherias eleftherias self-assigned this Dec 1, 2021
eleftherias
eleftherias suggested changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcusdacoregio!
I have left some feedback inline.
Also, since 5.6 was already released, the @since tags should be updated to 5.7.

...n/java/org/springframework/security/config/annotation/web/configurers/HeadersConfigurer.java Outdated Show resolved Hide resolved
...n/java/org/springframework/security/web/header/writers/CrossOriginPoliciesHeadersWriter.java Outdated Show resolved Hide resolved
config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java Outdated Show resolved Hide resolved
...g/springframework/security/web/server/header/CrossOriginPoliciesServerHttpHeadersWriter.java Outdated Show resolved Hide resolved
@marcusdacoregio marcusdacoregio removed the request for review from jzheaux December 3, 2021 19:38
@marcusdacoregio marcusdacoregio modified the milestones: 5.7.x, 5.7.0-M1 Dec 3, 2021
@marcusdacoregio marcusdacoregio force-pushed the gh-9385 branch 2 times, most recently from 9413b38 to 5099cae Compare December 3, 2021 19:51
@marcusdacoregio
Copy link
Contributor Author

Thanks for the review @eleftherias. I've updated the PR based on your suggestions.

@marcusdacoregio
Add Cross Origin Policies headers
aa3ee9d 
Add DSL support for Cross-Origin-Opener-Policy, Cross-Origin-Embedder-Policy and Cross-Origin-Resource-Policy headers

Closes spring-projectsgh-9385, spring-projectsgh-10118
@marcusdacoregio marcusdacoregio changed the base branch from main to 5.7.x December 7, 2021 14:15
@eleftherias eleftherias merged commit 65426a4 into spring-projects:5.7.x Dec 7, 2021
This was referenced Dec 7, 2021
Closed
Closed
@marcusdacoregio marcusdacoregio deleted the gh-9385 branch December 7, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias Awaiting requested review from eleftherias

Assignees

@eleftherias eleftherias

Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.7.0-M1
Development

Successfully merging this pull request may close these issues.

Add Cross-Origin-Opener-Policy and Cross-Origin-Embedder-Policy security headers
2 participants
@marcusdacoregio @eleftherias