Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace static "ROLE_" with customized role prefix #10078

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Replace static "ROLE_" with customized role prefix #10078

merged 1 commit into from
Sep 9, 2021

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jul 15, 2021

Fix gh-4134

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 15, 2021
@quaff quaff force-pushed the gh-4134 branch 2 times, most recently from d6f0b6c to 2bf8da4 Compare July 16, 2021 00:33
@quaff
Copy link
Contributor Author

quaff commented Jul 16, 2021

@rwinch Ready for review.

@sjohnr sjohnr added the in: config An issue in spring-security-config label Jul 16, 2021
@quaff
Copy link
Contributor Author

quaff commented Sep 1, 2021

Would any team member take a look at this? It's a simple fix.

@jzheaux jzheaux assigned jzheaux and unassigned rwinch Sep 3, 2021
@jzheaux jzheaux added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 3, 2021
jzheaux
jzheaux requested changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @quaff! Please see my feedback inline.

...amework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java Outdated Show resolved Hide resolved
...amework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java Outdated Show resolved Hide resolved
...amework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java Outdated Show resolved Hide resolved
...amework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java Outdated Show resolved Hide resolved
@quaff quaff force-pushed the gh-4134 branch 2 times, most recently from ca5ace1 to 4f16d55 Compare September 5, 2021 03:21
@quaff
Copy link
Contributor Author

quaff commented Sep 5, 2021

@jzheaux updated, please review.

@quaff quaff requested a review from jzheaux September 5, 2021 03:58
@jzheaux jzheaux added this to the 5.6.0-M3 milestone Sep 9, 2021
@jzheaux jzheaux merged commit f2b2e60 into spring-projects:main Sep 9, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Sep 9, 2021

Thanks, @quaff! This is now merged into main.

@sjohnr sjohnr added the status: duplicate A duplicate of another issue label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juncevich juncevich juncevich left review comments

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.6.0-M3
Development

Successfully merging this pull request may close these issues.

GrantedAuthorityDefaults does not apply on ExpressionInterceptUrlRegistry#hasRole
6 participants
@quaff @jzheaux @juncevich @rwinch @sjohnr @spring-projects-issues