Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to point to migrated samples #9816

Closed
jzheaux opened this issue May 26, 2021 · 0 comments
Closed

Update links to point to migrated samples #9816

jzheaux opened this issue May 26, 2021 · 0 comments
Assignees
@marcusdacoregio
Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.6.0-M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented May 26, 2021

In 5.5, gh-samples-url points to https://github.com/spring-projects/spring-security/tree/5.5.0/samples, but the samples have moved to spring-security-samples, so the links are broken.

For links that point to samples that have been migrated, they should point to the tagged version of the corresponding tag and sample in spring-security-samples.

Note that the docs should continue to use variables to compute the links in order to simplify future maintenance.

Since this first released in 5.5, these links should be backported to the 5.5 documentation as well.
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug labels May 26, 2021
@jzheaux jzheaux added this to the 5.6.0-M1 milestone May 26, 2021
@jzheaux jzheaux mentioned this issue May 26, 2021
Closed
6 tasks
@marcusdacoregio marcusdacoregio mentioned this issue Jun 4, 2021
Merged
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jun 21, 2021
@marcusdacoregio
Update links to point to migrated samples
5331099 
Closes spring-projectsgh-9816
marcusdacoregio added a commit that referenced this issue Jun 21, 2021
@marcusdacoregio
Update links to point to migrated samples
f9a7ae0 
Closes gh-9816
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Jun 21, 2021
Closed
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@marcusdacoregio
Update links to point to migrated samples
059811f 
Closes spring-projectsgh-9816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.6.0-M1
Development

No branches or pull requests
3 participants
@jzheaux @marcusdacoregio @spring-projects-issues