Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add messaging to documentation about sample migration #9815

Closed
jzheaux opened this issue May 26, 2021 · 0 comments · Fixed by #9826
Closed

Add messaging to documentation about sample migration #9815

jzheaux opened this issue May 26, 2021 · 0 comments · Fixed by #9826
Assignees
@marcusdacoregio
Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.6.0-M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented May 26, 2021

We should alert the community to where our samples are and that they are currently in migration to spring-security-samples.

An admonition in our documentation would likely suffice. It would explain where samples were (so that readers can find them in the meantime) and where they are now.

Since this first released in 5.5, this message should be backported to the 5.5 documentation as well.
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug labels May 26, 2021
@jzheaux jzheaux added this to the 5.6.0-M1 milestone May 26, 2021
@jzheaux jzheaux mentioned this issue May 26, 2021
Closed
6 tasks
@marcusdacoregio marcusdacoregio mentioned this issue Jun 4, 2021
Merged
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jun 21, 2021
@marcusdacoregio
Add messaging to documentation about sample migration
44cd700 
Closes spring-projectsgh-9815
marcusdacoregio added a commit that referenced this issue Jun 21, 2021
@marcusdacoregio
Add messaging to documentation about sample migration
d60981f 
Closes gh-9815
marcusdacoregio added a commit that referenced this issue Jun 21, 2021
@marcusdacoregio
Add messaging to documentation about sample migration
425d008 
Closes gh-9815
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Jun 21, 2021
Closed
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@marcusdacoregio
Add messaging to documentation about sample migration
30c07a3 
Closes spring-projectsgh-9815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.6.0-M1
Development

Successfully merging a pull request may close this issue.

Update Documentation to point to spring-security-samples marcusdacoregio/spring-security
3 participants
@jzheaux @marcusdacoregio @spring-projects-issues