Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SecurityContextHolderFilter #9635

Closed
Tracked by #10949
rwinch opened this issue Apr 13, 2021 · 0 comments
Closed
Tracked by #10949

Add SecurityContextHolderFilter #9635

rwinch opened this issue Apr 13, 2021 · 0 comments
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone
5.7.0-M3

Comments

@rwinch
Copy link
Member

rwinch commented Apr 13, 2021 •
edited
Loading

We should add a SecurityContextHolderFilter that loads the SecurityContext from the request. It will not automatically save the SecurityContext. Using this mechanism requires explicitly saving the SecurityContext rather than just setting the SecurityContextHolder. We also want to consider a simplified API to SecurityContextRepository.loadContext(HttpRequestResponseHolder) so that users do not need to worry about replacing the request/response. Perhaps just adding a default method to SecurityContextRepository.loadContext(HttpServletRequest,HttpServletResponse)

Related gh-9634 gh-10947
@rwinch rwinch added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 13, 2021
@rwinch rwinch added this to the 5.6.0-M1 milestone Apr 13, 2021
@eleftherias eleftherias modified the milestones: 5.6.0-M1, 5.6.0-M2 Jul 19, 2021
@rwinch rwinch modified the milestones: 5.6.0-M2, 5.6.0-M3 Aug 16, 2021
@sjohnr sjohnr modified the milestones: 5.6.0-M3, 5.6.0-RC1 Sep 20, 2021
@rwinch rwinch modified the milestones: 5.6.0-RC1, 5.6.0 Oct 19, 2021
@rwinch rwinch modified the milestones: 5.6.0, 5.7.0-M1 Nov 12, 2021
@sjohnr sjohnr modified the milestones: 5.7.0-M1, 5.7.0-M2 Jan 14, 2022
@marcusdacoregio marcusdacoregio modified the milestones: 5.7.0-M2, 5.7.0-M3 Feb 21, 2022
@rwinch rwinch mentioned this issue Mar 9, 2022
Closed
3 tasks
rwinch added a commit that referenced this issue Mar 11, 2022
@rwinch
Extract createSecurityContextRepository()
dbcb500 
Extract out method in preparation for adding SecurityContextHolderFilter
configuration.

Issue gh-9635
rwinch added a commit that referenced this issue Mar 11, 2022
@rwinch
Add SecurityContextHolderFilter
87ed31a 
Closes gh-9635
rwinch added a commit that referenced this issue Mar 12, 2022
@rwinch
Extract createSecurityContextRepository()
f9619ce 
Extract out method in preparation for adding SecurityContextHolderFilter
configuration.

Issue gh-9635
@rwinch rwinch closed this as completed in 972039e Mar 12, 2022
rwinch added a commit that referenced this issue Mar 12, 2022
@rwinch
Fix docs SecurityContextHolder Diagram
c49d47d 
Issue gh-9635
rwinch added a commit that referenced this issue Mar 12, 2022
@rwinch
Fix docs SecurityContextHolder Diagram
fabeabd 
Issue gh-9635
rwinch added a commit that referenced this issue Apr 13, 2022
@rwinch
Add test support for SecurityContextHolderFilter
b1233d0 
Issue gh-9635
rwinch added a commit that referenced this issue Apr 13, 2022
@rwinch
Add test support for SecurityContextHolderFilter
6e6d472 
Issue gh-9635
@marcusdacoregio marcusdacoregio mentioned this issue Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
5.7.0-M3
Development

No branches or pull requests
4 participants
@rwinch @sjohnr @eleftherias @marcusdacoregio