-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling logout keeps LogoutPageGeneratingWebFilter registered at /logout #9475
Labels
in: config
An issue in spring-security-config
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
Milestone
Comments
kkroner8451
added
status: waiting-for-triage
An issue we've not yet triaged
type: bug
A general bug
labels
Feb 25, 2021
Thanks for the report. A few additional thoughts:
|
eleftherias
added
in: config
An issue in spring-security-config
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Mar 1, 2021
eleftherias
added a commit
that referenced
this issue
Jun 17, 2021
spring-projects-issues
added
the
status: backported
An issue that has been backported to maintenance branches
label
Jun 17, 2021
eleftherias
added a commit
that referenced
this issue
Jun 17, 2021
eleftherias
added a commit
that referenced
this issue
Jun 18, 2021
eleftherias
added a commit
that referenced
this issue
Jun 18, 2021
akohli96
pushed a commit
to akohli96/spring-security
that referenced
this issue
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: config
An issue in spring-security-config
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
Describe the bug
When configuring
SecurityWebFilterChain
withhttp.logout().disable()
the defaultLogoutPageGeneratingWebFilter
is still created, registered and listening to GET calls to /logout. It seems there is no way to disable this or change the route matcher to anything other than GET on /logout.To Reproduce
Register a SecurityWebFilterChain bean similar to:
Navigate in browser to http://hostname/logout and the default logout page is shown asking if you want to logout.
Expected behavior
I would expect that if logout is disabled then the logout page generating filter would not be registered/listening at /logout. Alternatively, I would have expected that if changing the
logout.logoutUrl("/someOtherLogout")
then the page generating filter would have been changed to that location as well or even better that the matcher could be set explicitly on theLogoutPageGeneratingWebFilter
in a similar way as thelogout().requiresLogout(ServerWebExchangeMatchers.pathMatchers(HttpMethod.GET, "/customLogoutPath"));
Sample
A link to a GitHub repository with a minimal, reproducible sample.
Reports that include a sample will take priority over reports that do not.
At times, we may require a sample, so it is good to try and include a sample up front.
The text was updated successfully, but these errors were encountered: