Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guidelines to require JDK 11 to build #9418

Closed
jzheaux opened this issue Feb 8, 2021 · 5 comments
Closed

Update contribution guidelines to require JDK 11 to build #9418

jzheaux opened this issue Feb 8, 2021 · 5 comments
Assignees
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Feb 8, 2021

As part of updating Spring Security's build to require JDK 11, the contribution guidelines should be updated.

@jzheaux jzheaux added in: docs An issue in Documentation or samples type: enhancement A general enhancement labels Feb 8, 2021
@jzheaux jzheaux self-assigned this Feb 8, 2021
jzheaux added a commit to jzheaux/spring-security that referenced this issue Feb 17, 2021
@manueljordan
Copy link

Hi @jzheaux

The build.gradle file, should be updated too? Currently, it has:

plugins.withType(JavaPlugin) {
		project.sourceCompatibility='1.8'
	}

@jzheaux
Copy link
Contributor Author

jzheaux commented Feb 23, 2021

Good question, @manueljordan. No, this should not be updated as Spring Security 5 guarantees Java 8 source compatibility.

Even though Spring Security may require compilation with JDK 11, it should not require JDK 11 to use it in a project.

@manueljordan
Copy link

Even though Spring Security may require compilation with JDK 11, it should not require JDK 11 to use it in a project.

Interesting perspective

@jzheaux
Copy link
Contributor Author

jzheaux commented Mar 8, 2021

@manueljordan This is the kind of long-term compatibility that the Spring Framework has become known for. You can see another example of the same thing from when Java 8 APIs started getting introduced. Even though Spring Framework required Java 8 to build it, Java 6 applications could still use it just fine.

@manueljordan
Copy link

@jzheaux - Thanks for information and the interesting link, I appreciate that

@jzheaux jzheaux added this to the 5.5.0-M3 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants