Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasAnyAuthority(String...) and hasAnyRole(String...) to authorizeRequests in Kotlin DSL #8892

Closed
koishikawa11 opened this issue Aug 1, 2020 · 2 comments · Fixed by #8926
Closed

Add hasAnyAuthority(String...) and hasAnyRole(String...) to authorizeRequests in Kotlin DSL #8892

koishikawa11 opened this issue Aug 1, 2020 · 2 comments · Fixed by #8926
Assignees
@eleftherias
Labels
in: config An issue in spring-security-config status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Milestone
5.4.0

Comments

@koishikawa11
Copy link
Contributor

Expected Behavior

The Kotlin DSL has methods for conveniently specifying the access hasAuthority(String) and hasRole(String) in authorizeRequests.
I think it would be convenient to have method for hasAnyAuthority(String...) and hasAnyRole(String...).

Current Behavior

In the current version it is necessary to create access like "hasAnyAuthority('$anyAuthorities')".
@koishikawa11 koishikawa11 added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Aug 1, 2020
@eleftherias eleftherias added in: config An issue in spring-security-config and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 4, 2020
@eleftherias
Copy link
Contributor

eleftherias commented Aug 4, 2020 •
edited
Loading

Thanks for the suggestion @koishikawa11.
Are you interested in submitting a pull request for this feature?

@koishikawa11
Copy link
Contributor Author

Yes, I would like to create a pull request.

@eleftherias eleftherias added the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Aug 5, 2020
@koishikawa11 koishikawa11 mentioned this issue Aug 5, 2020
Merged
eleftherias pushed a commit that referenced this issue Aug 11, 2020
@koishikawa11
Add hasAnyRole and hasAnyAuthority to authorizeRequests in Kotlin DSL
be6d2f1 
Closes gh-8892
@eleftherias eleftherias added this to the 5.4.0 milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

Labels
in: config An issue in spring-security-config status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0
Development

Successfully merging a pull request may close this issue.

Add hasAnyRole and hasAnyAuthority to authorizeRequests in Kotlin DSL
2 participants
@eleftherias @koishikawa11