Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSessionServerRequestCache doesn't save URL query parameters #6421

Closed
denisw opened this issue Jan 14, 2019 · 0 comments
Closed

WebSessionServerRequestCache doesn't save URL query parameters #6421

denisw opened this issue Jan 14, 2019 · 0 comments
Assignees
@rwinch
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Milestone
5.2.0.M1

Comments

@denisw
Copy link
Contributor

denisw commented Jan 14, 2019

Summary

When protecting a Webflux route with oauth2login(), the redirect back to that route after login misses any query parameters passed in the original request to that route. That seems to be caused by WebSessionServerRequestCache only saving the path, not the parameters.

For the purposes of the following sections, let's say the client requests GET /protected?foo=bar, but is not logged in yet.

Actual Behavior

After the OAuth2 login flow succeeded, the client gets redirected to /protected (note the missing ?foo=bar).

Expected Behavior

The query parameters are retained. The redirect after login would go to /protected?foo=bar.

Details

It seems as if WebSessionServerRequestCache only saves the request path. It should save URL query parameters in addition.
@rwinch rwinch added status: ideal-for-contribution An issue that we actively are looking for someone to help us with status: waiting-for-triage An issue we've not yet triaged and removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Jan 14, 2019
@denisw denisw mentioned this issue Jan 15, 2019
Merged
@rwinch rwinch removed the status: waiting-for-triage An issue we've not yet triaged label Jan 15, 2019
@rwinch rwinch self-assigned this Jan 15, 2019
@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: bug A general bug Reactive labels Jan 15, 2019
@rwinch rwinch added this to the 5.2.0.M1 milestone Jan 15, 2019
@rwinch rwinch mentioned this issue Jan 15, 2019
Closed
rwinch pushed a commit that referenced this issue Jan 15, 2019
@denisw @rwinch
Save query parameters in WebSessionServerRequestCache
548dc44 
Previously, URL query parameters were lost when saving a request
in WebSessionServerRequestCache. Now it is properly saved and
restored.

Fixes: gh-6421
@rwinch rwinch mentioned this issue Jan 15, 2019
Closed
rwinch added a commit that referenced this issue Jan 15, 2019
@rwinch
Save query parameters in WebSessionServerRequestCache
f8ee28e 
Previously, URL query parameters were lost when saving a request
in WebSessionServerRequestCache. Now it is properly saved and
restored.

Fixes: gh-6421
@eleftherias eleftherias mentioned this issue Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Milestone
5.2.0.M1
Development

No branches or pull requests
2 participants
@rwinch @denisw