Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PowerMock Dependency #6025

Closed
jzheaux opened this issue Oct 26, 2018 · 3 comments
Closed

Remove PowerMock Dependency #6025

jzheaux opened this issue Oct 26, 2018 · 3 comments
Assignees
@rwinch
Labels
in: test An issue in spring-security-test type: enhancement A general enhancement
Milestone
5.6.0-M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Oct 26, 2018

PowerMock does not have a GA release that is compatible with JDK 12, nor is one currently planned.

Let's convert tests that are currently using PowerMock so that we can move forward with JDK 12.
@jzheaux jzheaux added this to the 5.2.x milestone Oct 26, 2018
@jzheaux jzheaux added the in: test An issue in spring-security-test label Oct 26, 2018
@jzheaux jzheaux modified the milestones: 5.2.x, 5.2.0.M1 Oct 30, 2018
jzheaux added a commit that referenced this issue Nov 20, 2018
@jzheaux
Add scopes method to TestOAuth2AccessTokens
39933b1 
Issue: gh-6025
jzheaux added a commit that referenced this issue Nov 20, 2018
@jzheaux
Remove PowerMock from oauth2-client
80e13ba 
Issue: gh-6025
jzheaux added a commit that referenced this issue Nov 20, 2018
@jzheaux
Remove PowerMock from oauth2-core and oauth2-jose
2a8233d 
Issue: gh-6025
jer051 pushed a commit to jer051/spring-security that referenced this issue Nov 21, 2018
@jzheaux
Add scopes method to TestOAuth2AccessTokens
045c841 
Issue: spring-projectsgh-6025
jer051 pushed a commit to jer051/spring-security that referenced this issue Nov 21, 2018
@jzheaux
Remove PowerMock from oauth2-client
4ebb76e 
Issue: spring-projectsgh-6025
@jzheaux jzheaux mentioned this issue Dec 3, 2018
Closed
7 tasks
@rwinch rwinch modified the milestones: 5.2.0.M1, 5.2.0.M2 Jan 16, 2019
@jzheaux jzheaux self-assigned this Feb 8, 2019
@jzheaux jzheaux modified the milestones: 5.2.0.M2, General Backlog Apr 9, 2019
@jzheaux
Copy link
Contributor Author

jzheaux commented Apr 9, 2019

Note that PowerMock released a 2.0.0 version that addresses the JDK 12 issue. because of this, we don't need this as immediately, but will keep it open as there is still value in reducing dependencies. For example, if Mockito adds support for static methods, it would be nice to use only one mocking library going forward.

@rwinch
Copy link
Member

rwinch commented Aug 22, 2019

We can remove the need for powermock for mocking classpath by using https://github.com/spring-projects/spring-boot/tree/b43827d6264a3eb4e9558c6e1dd7f89e537caa96/spring-boot-project/spring-boot-tools/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/classpath

@jzheaux jzheaux removed their assignment Apr 14, 2020
@eleftherias
Copy link
Contributor

Mockito has added support for static methods as of 3.4.0 https://github.com/mockito/mockito/releases/tag/v3.4.0

@eleftherias eleftherias mentioned this issue Jul 13, 2020
Closed
@rwinch rwinch self-assigned this Jul 7, 2021
@rwinch rwinch modified the milestones: General Backlog, 5.6.0-M1 Jul 8, 2021
@rwinch rwinch added the type: enhancement A general enhancement label Jul 8, 2021
@rwinch rwinch closed this as completed in 14240b2 Jul 8, 2021
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jul 27, 2021
@marcusdacoregio
Fix test getting stuck
9024e86 
The tests are getting stuck when running a single test class and the mock is performed in a static variable inside an inner class

Issue spring-projectsgh-6025
jzheaux pushed a commit that referenced this issue Jul 27, 2021
@marcusdacoregio @jzheaux
Fix test getting stuck
662ab10 
The tests are getting stuck when running a single test class and the mock is performed in a static variable inside an inner class

Issue gh-6025
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@rwinch
Remove Powermock
d132935 
Powermock does not support JUnit5 yet, so we need to remove it
to support JUnit 5. Additionally, maintaining additional libraries
adds extra work for the team.

Mockito now supports final classes and static method mocking. This
commit replaces Powermock with mockito-inline.

Closes spring-projectsgh-6025
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@marcusdacoregio
Fix test getting stuck
20b2310 
The tests are getting stuck when running a single test class and the mock is performed in a static variable inside an inner class

Issue spring-projectsgh-6025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: test An issue in spring-security-test type: enhancement A general enhancement
Projects
None yet
Milestone
5.6.0-M1
Development

No branches or pull requests
3 participants
@rwinch @jzheaux @eleftherias