Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configurable RestOperations for DefaultOAuth2UserService #5600

Closed
jgrandja opened this issue Jul 30, 2018 · 0 comments
Closed

Allow configurable RestOperations for DefaultOAuth2UserService #5600

jgrandja opened this issue Jul 30, 2018 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.1.0.RC2

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Jul 30, 2018 •
edited
Loading

DefaultOAuth2UserService uses Nimbus's HTTP Client internally to retrieve the UserInfo resource.

We should re-factor to use RestOperations instead and additionally expose a DefaultOAuth2UserService.setRestOperations(restOperations) to allow user's the ability to supply a pre-configured RestOperations that are capable of adding custom parameters and/or headers.

Related #5601
@jgrandja jgrandja self-assigned this Jul 30, 2018
@jgrandja jgrandja added this to the 5.1.0.RC1 milestone Jul 30, 2018
@jgrandja jgrandja added type: enhancement A general enhancement Refactoring in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Jul 30, 2018
This was referenced Jul 30, 2018
Closed
Closed
@jgrandja jgrandja mentioned this issue Aug 4, 2018
Merged
@jgrandja jgrandja modified the milestones: General Backlog, 5.1.0.RC2 Aug 21, 2018
jgrandja added a commit to jgrandja/spring-security that referenced this issue Aug 28, 2018
@jgrandja
Provide RestOperations in DefaultOAuth2UserService
b85a42f 
Fixes spring-projectsgh-5600
rwinch pushed a commit that referenced this issue Sep 5, 2018
@jgrandja @rwinch
Provide RestOperations in DefaultOAuth2UserService
4a8c95a 
Fixes gh-5600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.0.RC2
Development

No branches or pull requests
2 participants
@rwinch @jgrandja