Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSRF doc issue spring-security 6.0.x #13910

Closed
JurrianFahner opened this issue Sep 30, 2023 · 1 comment
Closed

CSRF doc issue spring-security 6.0.x #13910

JurrianFahner opened this issue Sep 30, 2023 · 1 comment
Assignees
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement

Comments

@JurrianFahner
Copy link

Recently I was upgrading a spring-boot app from 2.x to 3.x. This app has also a dependency on spring-cloud, so I'm not able to upgrade to spring-boot 6.1.x.

I ran into an issue with CSRF and I was clueless how to solve it, the documentation of 6.0.x. made it clear that there were changes due to the BREACH vulnerability. Today I was able to solve it by applying the documentation for 6.1.x to my problem and it was fixed.

It would be very beneficial for other users that the 6.1.x documentation for CSRF can be applied to the 6.0.x branch as well.
Even better would be to add this section to 6.0.x. Maybe all of CSRF is applicable to 6.0.x, I didn't analyze the changes between 6.0.x and 6.1.x to check whether it would be a complete fit.

@JurrianFahner JurrianFahner added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Sep 30, 2023
@sjohnr sjohnr self-assigned this Oct 10, 2023
@sjohnr sjohnr moved this to Prioritized in Spring Security Team Oct 10, 2023
@sjohnr sjohnr added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 10, 2023
@sjohnr sjohnr closed this as completed in 7d5a541 Oct 10, 2023
@sjohnr
Copy link
Member

sjohnr commented Oct 10, 2023

Thanks for the feedback @JurrianFahner! I discussed this with the team and we agreed that this should be backported to 6.0 documentation. This will appear with the next patch release on Monday.

@sjohnr sjohnr moved this from Prioritized to Done in Spring Security Team Oct 10, 2023
sjohnr added a commit that referenced this issue Oct 10, 2023
(cherry picked from commit ac7fbea)

Issue gh-13910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
Archived in project
Development

No branches or pull requests

2 participants