Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider OIDC Back-Channel favoring logout_token over CSRF #13841

Closed
jzheaux opened this issue Sep 16, 2023 · 2 comments
Closed

Consider OIDC Back-Channel favoring logout_token over CSRF #13841

jzheaux opened this issue Sep 16, 2023 · 2 comments
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Sep 16, 2023

The current OIDC back-channel logout support saves the end-user's CSRF token to use in a self-logout call when the back-channel request comes from the authorization server.

This adds more information to OidcSessionInformation than may be necessary. Instead, I think it would also work to send the logout_token in place of the CSRF token.

The upside is a simpler contract and simpler configuration. The possible downside is the logout token is validated multiple times, once for each session being invalidated.

@jzheaux jzheaux added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Sep 16, 2023
@jzheaux jzheaux self-assigned this Sep 16, 2023
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 16, 2023
@jzheaux jzheaux added the status: blocked An issue that's blocked on an external project change label Jan 31, 2024
@jzheaux
Copy link
Contributor Author

jzheaux commented Jan 31, 2024

Waiting on #14510

@jzheaux
Copy link
Contributor Author

jzheaux commented Jul 22, 2024

Given the feedback in #15227, I think that's enough to consider adding this without waiting for #14510.

@jzheaux jzheaux removed the status: blocked An issue that's blocked on an external project change label Jul 22, 2024
@jzheaux jzheaux added this to the 6.4.x milestone Jul 22, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Aug 8, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Aug 8, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Aug 8, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Aug 8, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 4, 2024
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 16, 2024
This component already uses by default a URI that doesn't require
a CSRF token and aalready allows for configuring a cookie name.

So, by making it public and configurable in the DSL, both
of these tickets quite naturally close.

Closes spring-projectsgh-13841
Closes spring-projectsgh-14904
jzheaux added a commit to jzheaux/spring-security that referenced this issue Sep 16, 2024
This component already uses by default a URI that doesn't require
a CSRF token and aalready allows for configuring a cookie name.

So, by making it public and configurable in the DSL, both
of these tickets quite naturally close.

Closes spring-projectsgh-13841
Closes spring-projectsgh-14904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
Archived in project
Development

No branches or pull requests

1 participant