Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saml2Login should not override OpenSaml4AuthenticationProvider bean #13654

Closed
jzheaux opened this issue Aug 16, 2023 · 0 comments
Closed

saml2Login should not override OpenSaml4AuthenticationProvider bean #13654

jzheaux opened this issue Aug 16, 2023 · 0 comments
Assignees
@jzheaux
Labels
in: config An issue in spring-security-config type: bug A general bug
Milestone
6.0.6

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Aug 16, 2023

Because the saml2Login DSL calls HttpSecurity#authenticationProvider to register its AuthenticationProvider, this overrides when an application declares OpenSaml4AuthenticationProvider as a bean.

It's expected that unless an application calls HttpSecurity#authenticationProvider, then the bean declaration should take precedence.
@jzheaux jzheaux added in: config An issue in spring-security-config type: bug A general bug labels Aug 16, 2023
@jzheaux jzheaux added this to the 5.8.6 milestone Aug 16, 2023
@jzheaux jzheaux self-assigned this Aug 16, 2023
@jzheaux jzheaux modified the milestones: 5.8.6, 6.0.6 Aug 16, 2023
@jzheaux jzheaux mentioned this issue Aug 16, 2023
Closed
jzheaux added a commit that referenced this issue Oct 2, 2023
@jzheaux
Polish OAuth2AuthorizationManagers
a3227f0 
- Add OAuth2ReactiveAuthorizationManagers
- Code to interfaces
- Align error message with the same in
AuthorityAuthorizationManager
- Adjust expectations in tests to confirm an
appropriately constructed authorizaion manager
- Add JavaDoc and reference documentation

Issue gh-13654
jzheaux added a commit that referenced this issue Oct 2, 2023
@jzheaux
Fix Formatting
c7ea8c6 
Issue gh-13654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config type: bug A general bug
Projects
None yet
Milestone
6.0.6
Development

No branches or pull requests
1 participant
@jzheaux