Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to mockito 4.11.0 causes OAuth2LoginBeanDefinitionParserTests and OAuth2ClientBeanDefinitionParserTests to fail #13546

Open
jzheaux opened this issue Jul 15, 2023 · 0 comments
Open

Updating to mockito 4.11.0 causes OAuth2LoginBeanDefinitionParserTests and OAuth2ClientBeanDefinitionParserTests to fail #13546

jzheaux opened this issue Jul 15, 2023 · 0 comments
Labels
in: config An issue in spring-security-config type: bug A general bug

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jul 15, 2023

In some way, mocking the OAuth2AuthorizedClientRepository and publishing it as a bean causes Spring MVC's RequestMappingHandlerAdapter bean to be constructed before the OAuth2AuthorizedClientArgumentResolver can be registered.

Changing the corresponding tests to use HttpSessionOAuth2AuthorizedClientRepository addressed the issue so that the upgrade could happen, though this should still be investigated to find the root cause.
@jzheaux jzheaux added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug in: config An issue in spring-security-config and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 15, 2023
jzheaux added a commit that referenced this issue Jul 15, 2023
@jzheaux
Don't Mock OAuth2AuthorizedClientRepository
b3ad2b0 
Issue gh-13542
Issue gh-13546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: config An issue in spring-security-config type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jzheaux