Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Querying of RequestCache -> continue parameter #13438

Closed
Writtscher opened this issue Jun 30, 2023 · 1 comment
Closed

Optimize Querying of RequestCache -> continue parameter #13438

Writtscher opened this issue Jun 30, 2023 · 1 comment
Assignees
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Milestone

Comments

@Writtscher
Copy link

Expected Behavior

Do not append endless continue parameters.

Current Behavior

Adds endless continue parameters

Context

I have implemented a simple oidc login to play with the new api / version. Whenever the login succeeds I see a continue parameter. I understand why this is the case: https://docs.spring.io/spring-security/reference/5.8/migration/servlet/session-management.html#requestcache-query-optimization . But I do not understand why it does append everytime I remove the jsessionid another continue parameter. I mean if the url already contains the continue parameter than there is no reason to append another one. Or am I mistaken?

In short: When I login I am redirected to my requested url http://localhost:8080/xxx?continue. When I remove the jsessionid and reload the page I am redirected to http://localhost:8080/xxx?continue&continue. When I repeat it I am redirected to http://localhost:8080/xxx?continue&continue&continue.

@Writtscher Writtscher added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Jun 30, 2023
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Jul 10, 2023
@jzheaux jzheaux added this to the 5.8.5 milestone Jul 10, 2023
@jzheaux jzheaux self-assigned this Jul 10, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Jul 10, 2023

Thanks for the report, @Writtscher. I've pushed a fix, and it should go out with the next set of releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants