Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After version 1.1.1, when continue parameter is prefilled, it is not possible to call the endpoint /token #1333

Closed
Daniel100262 opened this issue Aug 14, 2023 · 2 comments
Assignees
Labels
status: invalid An issue that we don't feel is valid

Comments

@Daniel100262
Copy link

Describe the bug
After version 1.1.1, an implementation was changed and is causing a bug when parameter continue is submitted with URL. This implementation occours in class OAuth2AuthorizationCodeRequestAuthenticationConverter in line 141 .

After this, the request is being converted from an arraylist to a array of String, as below:

image

After that, when the repository looks on database table for the authorization code to perform the exchange for a token, he find this on column attributes of oauth2_authorization table:

&continue=%5BLjava.lang.String;@a598662

Then the String array has no serializer registered and the following error occurs:

image

Spring Security bug in "continue" parameter related here maybe affect that issue: spring-projects/spring-security#13438

To Reproduce
Make an request to authorize endpoint with "continue" parameter using authorization code flow. After that, make an request to "token" endpoint to perform the exchange for a token.

Expected behavior
Make the exchange without any issues.

@Daniel100262 Daniel100262 added the type: bug A general bug label Aug 14, 2023
@jgrandja
Copy link
Collaborator

@Daniel100262 I ran the demo sample, which appends the continue parameter (see attached), but was not able to reproduce the error.

Continue-param

Did you try it with the demo sample? Please provide more detailed steps on how to reproduce.

@jgrandja jgrandja added status: waiting-for-feedback We need additional information before we can continue and removed type: bug A general bug labels Aug 18, 2023
@Daniel100262
Copy link
Author

Hello @jgrandja, I solved this problem by upgrading from Spring Boot from 3.1.1 to 3.1.2. This updates Spring Security to version 6.1.2, where there is already a fix for the "continue" case, which also solves the desserialization problem.

If anyone else is having this type of problem, this would be the solution.

@jgrandja jgrandja self-assigned this Aug 18, 2023
@jgrandja jgrandja added status: invalid An issue that we don't feel is valid and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

2 participants