Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthorizationManagers should allow a configurable default AuthorizationDecision #13085

Closed
jzheaux opened this issue Apr 24, 2023 · 2 comments · Fixed by #14180
Closed

AuthorizationManagers should allow a configurable default AuthorizationDecision #13085

jzheaux opened this issue Apr 24, 2023 · 2 comments · Fixed by #14180
Assignees
@jzheaux @FdHerrera
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Apr 24, 2023

When all delegates abstain, AuthorizationManagers's composition implementations return a default AuthorizationDecision. It would be nice if this default decision were configurable.

One way to do this would be to introduce:

public static <T> AuthorizationManager<T> anyOf(AuthorizationDecision allAbstainDefaultDecision, AuthorizationManager<T>... managers);

public static <T> AuthorizationManager<T> allOf(AuthorizationDecision allAbstainDefaultDecision, AuthorizationManager<T>... managers);
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Apr 24, 2023
@jzheaux jzheaux mentioned this issue Apr 24, 2023
Closed
@evgeniycheban
Copy link
Contributor

evgeniycheban commented May 19, 2023 •
edited
Loading

@jzheaux I can take this.

@FdHerrera
Copy link

Hello,

I'd like to contribute to this project by taking this issue if it's ok for you.

Thank you in advance!

@ysavchen ysavchen mentioned this issue Nov 21, 2023
Merged
@FdHerrera FdHerrera mentioned this issue Nov 22, 2023
Closed
@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Nov 28, 2023
jzheaux pushed a commit that referenced this issue Dec 7, 2023
@ysavchen @jzheaux
Add AuthorizationManager factory methods
e49ae09 
Factory methods to create AuthorizationManager with a configurable default AuthorizationDecision.

Closes gh-13085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

@FdHerrera FdHerrera

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
3 participants
@jzheaux @evgeniycheban @FdHerrera