Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecurityWebApplicationInitializer.getSecurityDispatcherTypes example is wrong in migration guide #12939

Closed
Brummolix opened this issue Mar 28, 2023 · 3 comments
Closed

SecurityWebApplicationInitializer.getSecurityDispatcherTypes example is wrong in migration guide #12939

Brummolix opened this issue Mar 28, 2023 · 3 comments
Assignees
@marcusdacoregio
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Milestone
5.8.3

Comments

@Brummolix
Copy link
Contributor

In https://docs.spring.io/spring-security/reference/5.8/migration/servlet/authorization.html#switch-filter-all-dispatcher-types an example is listed to change getSecurityDispatcherTypes in SecurityWebApplicationInitializer.
In this example FORWARD is listed twice. I think ASYNC was meant instead?
@Brummolix Brummolix added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Mar 28, 2023
@marcusdacoregio marcusdacoregio self-assigned this Mar 29, 2023
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 29, 2023
@marcusdacoregio marcusdacoregio added this to the 5.8.3 milestone Mar 29, 2023
@marcusdacoregio
Copy link
Contributor

Hi @Brummolix, thanks for the report.

Yes, that should be ASYNC and not FORWARD twice. Are you interested in submitting a PR that fixes that?
The PR should target the 5.8.x branch

Brummolix added a commit to Brummolix/spring-security that referenced this issue Mar 29, 2023
@Brummolix
Fix SecurityWebApplicationInitializer.getSecurityDispatcherTypes exam…
373a569 
…ple in doc spring-projects#12939
@Brummolix Brummolix mentioned this issue Mar 29, 2023
Merged
@Brummolix
Copy link
Contributor Author

I created #12944

marcusdacoregio pushed a commit that referenced this issue Mar 30, 2023
@Brummolix @marcusdacoregio
Fix SecurityWebApplicationInitializer.getSecurityDispatcherTypes exam…
a513fc0 
…ple in doc #12939
@marcusdacoregio
Copy link
Contributor

Closed via #12944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Milestone
5.8.3
Development

No branches or pull requests
2 participants
@Brummolix @marcusdacoregio