Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Javadoc for class ExpressionAuthorizationDecision #12411

Closed
ghusta opened this issue Dec 16, 2022 · 3 comments
Closed

Incorrect Javadoc for class ExpressionAuthorizationDecision #12411

ghusta opened this issue Dec 16, 2022 · 3 comments
Assignees
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Milestone

Comments

@ghusta
Copy link
Contributor

ghusta commented Dec 16, 2022

Javadoc says ExpressionAuthorizationDecision was introduced since 5.6.

But in reality it was introduced in 5.8.

See source : https://github.com/spring-projects/spring-security/blob/5.8.x/core/src/main/java/org/springframework/security/authorization/ExpressionAuthorizationDecision.java

@ghusta ghusta added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Dec 16, 2022
@marcusdacoregio marcusdacoregio self-assigned this Dec 16, 2022
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 16, 2022
@marcusdacoregio
Copy link
Contributor

Hi @ghusta,

are you interested in submitting a PR targeting the 5.8.x branch that updates the since tag?

@ghusta
Copy link
Contributor Author

ghusta commented Dec 16, 2022

Hi

OK why not. In my opinion there is only one character to change, it shouldn't be too hard 😉

@marcusdacoregio
Copy link
Contributor

Sounds good, I'll assign this issue to you then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants