Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the RP-initiated Logout links #12081

Closed
rozagerardo opened this issue Oct 25, 2022 · 1 comment · Fixed by #12082
Closed

Update the RP-initiated Logout links #12081

rozagerardo opened this issue Oct 25, 2022 · 1 comment · Fixed by #12082
Assignees
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Milestone

Comments

@rozagerardo
Copy link
Contributor

Describe the bug
We're using the following link when we refer to the OIDC RP-Initiated Logout feature:

https://openid.net/specs/openid-connect-session-1_0.html#RPLogout

But it seems this spec is not related to the feature anymore, in fact, the #RPLogout fragment doesn't seem to correspond to any section/element in the document.

This seems to be the correct link to the RP-Initiated spec:

https://openid.net/specs/openid-connect-rpinitiated-1_0.html

To Reproduce
Browse the following section in our docs:

https://docs.spring.io/spring-security/reference/servlet/oauth2/login/advanced.html#oauth2login-advanced-oidc-logout

and click on the following link:

One of the strategies available is RP-Initiated Logout.

The link will redirect to an OIDC spec that doesn't contain much RP-Initiated Logout info, which might be a little misleading.

Expected behavior
The links should point to the correct OIDC Spec:

https://openid.net/specs/openid-connect-rpinitiated-1_0.html

Sample
N/A

@rozagerardo
Copy link
Contributor Author

Here is a small PR to fix this, in case you agree the links should be updated:

#12082

@marcusdacoregio marcusdacoregio assigned sjohnr and jzheaux and unassigned sjohnr Oct 27, 2022
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 27, 2022
@marcusdacoregio marcusdacoregio added this to the 5.6.9 milestone Oct 27, 2022
rozagerardo added a commit to rozagerardo/spring-security that referenced this issue Oct 28, 2022
The URLs we're using are not actually pointing to the OIDC RP-Initiated Logout Specs.

Fixes: spring-projectsgh-12081
rozagerardo added a commit to rozagerardo/spring-security that referenced this issue Oct 28, 2022
The URLs we're using are not actually pointing to the OIDC RP-Initiated Logout Specs.

Fixes: spring-projectsgh-12081
@marcusdacoregio marcusdacoregio modified the milestones: 5.6.9, 5.6.10 Oct 31, 2022
@jzheaux jzheaux closed this as completed in 8315545 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants