Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saml2MetadataFilter response should configure writer to UTF-8 #12026

Closed
SebastianS90 opened this issue Oct 14, 2022 · 0 comments
Closed

Saml2MetadataFilter response should configure writer to UTF-8 #12026

SebastianS90 opened this issue Oct 14, 2022 · 0 comments
Assignees
@marcusdacoregio
Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Milestone
5.6.10

Comments

@SebastianS90
Copy link

In this line, the Saml2MetadataFilter sends out the response without specifying an encoding. The response will therefore be encoded using the default ISO-8859-1 encoding (see getWriter Javadoc).

However, the xml file itself starts with <?xml version="1.0" encoding="UTF-8"?>.

This results in a broken file when using OpenSamlMetadataResolver.setEntityDescriptorCustomizer to add a <md:ServiceDescription> element containing special characters like German umlauts (äöü).
@SebastianS90 SebastianS90 added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Oct 14, 2022
@marcusdacoregio marcusdacoregio added in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 18, 2022
@marcusdacoregio marcusdacoregio self-assigned this Oct 18, 2022
@marcusdacoregio marcusdacoregio added this to the 5.6.9 milestone Oct 18, 2022
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Oct 18, 2022
@marcusdacoregio
Use UTF-8 in Saml2MetadataFilter response writer
1978a56 
Closes spring-projectsgh-12026
@marcusdacoregio marcusdacoregio mentioned this issue Oct 18, 2022
Merged
@marcusdacoregio marcusdacoregio modified the milestones: 5.6.9, 5.6.10 Oct 31, 2022
This was referenced Nov 16, 2022
Closed
Closed
Closed
marcusdacoregio added a commit that referenced this issue Nov 16, 2022
@marcusdacoregio
Specify UTF8 for response content
d5aabd7 
This is needed because in some other platforms, like Windows, the default charset might be different

Issue gh-12026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Projects
None yet
Milestone
5.6.10
Development

No branches or pull requests
2 participants
@SebastianS90 @marcusdacoregio