Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for LazyCsrfTokenRepository to Defer Loading CsrfTokens #11700

Closed
Tracked by #11456
rwinch opened this issue Aug 11, 2022 · 0 comments
Closed
Tracked by #11456

Add Support for LazyCsrfTokenRepository to Defer Loading CsrfTokens #11700

rwinch opened this issue Aug 11, 2022 · 0 comments
Assignees
@rwinch
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone
5.8.0-M3

Comments

@rwinch
Copy link
Member

rwinch commented Aug 11, 2022 •
edited
Loading

LazyCsrfTokenRepository supports lazily saving the CsrfToken which allowed for lazily saving the CsrfToken. However, it does not support lazily reading the CsrfToken. This means every request requires reading the CsrfToken (often the HttpSession).

We should add support for lazily reading the CsrfToken and thus prevent unnecessary reads to the HttpSession.
@rwinch rwinch mentioned this issue Aug 11, 2022
Closed
2 tasks
@rwinch rwinch self-assigned this Aug 11, 2022
@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Aug 11, 2022
@rwinch rwinch modified the milestones: 5.8.0-M2, 5.8.0-M3 Aug 11, 2022
rwinch added a commit that referenced this issue Aug 16, 2022
@rwinch
LazyCsrfTokenRepository#loadToken Supports Deferring Delegation
666f175 
Previously LazyCsrfTokenRepository supported lazily saving the CsrfToken
which allowed for lazily saving the CsrfToken. However, it did not
support lazily reading the CsrfToken. This meant every request required
reading the CsrfToken (often the HttpSession).

This commit allows for lazily reading the CsrfToken and thus prevents
unnecessary reads to the HttpSession.

Closes gh-11700
@rwinch rwinch closed this as completed in 2aedf58 Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
5.8.0-M3
Development

No branches or pull requests
1 participant
@rwinch