Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding softlink from spring-security.xsd to latest schema #11365

Closed
sjohnr opened this issue Jun 10, 2022 · 8 comments
Closed

Consider adding softlink from spring-security.xsd to latest schema #11365

sjohnr opened this issue Jun 10, 2022 · 8 comments
Assignees
Labels
in: docs An issue in Documentation or samples type: task A general task
Milestone

Comments

@sjohnr
Copy link
Member

sjohnr commented Jun 10, 2022

We should consider adding a relative softlink in config/src/main/resources/org/springframework/security/config so that spring-security.xsd points to the latest schema.

Context

A configuration change was made to allow spring-security-*.xsd files available under https://www.springframework.org/schema/security/ to be automatically linked to the latest artifact extracted to /var/www/domains/spring.io/docs/htdocs/autorepo/schema on the web host (see gh-11353).

However, the file spring-security.xsd was manually updated to be a softlink to the latest schema (e.g. spring-security-5.7.xsd).

@sjohnr sjohnr added in: docs An issue in Documentation or samples type: task A general task labels Jun 10, 2022
@sjohnr sjohnr added this to the 5.8.x milestone Jun 10, 2022
@sjohnr sjohnr self-assigned this Jun 10, 2022
@rwinch
Copy link
Member

rwinch commented Jun 14, 2022

Just curious if you were aware that this is used for symlink creation https://github.com/spring-io/autoln

@sjohnr
Copy link
Member Author

sjohnr commented Jun 15, 2022

For sure! I discussed this with @trevormarshall recently, as we were working through gh-11353.

Since the file spring-security.xsd is already inside a directory that is managed through autoln (/var/www/domains/spring.io/docs/htdocs/autorepo/schema/spring-security/current/spring-security.xsd), the softlink was added manually for the time being. Is there a way for autoln to manage a single file under another autoln directory?

@trevormarshall
Copy link
Member

@sjohnr I think this might be what you mean https://github.com/spring-projects/spring-framework/wiki/autorepo-version-updating#autoschemaln

Shall we try touch /var/www/domains/spring.io/docs/htdocs/autorepo/schema/spring-security/.autoschemaln ?

@sjohnr
Copy link
Member Author

sjohnr commented Jul 7, 2022

Sorry for the delay on this, @trevormarshall. Your suggestion sounds good to me. Do we need to clean up the existing (manually created) symlink for spring-security.xsd first? I'm not sure how different layers of manual and automatic symlinks will interact with each other.

sjohnr added a commit to sjohnr/spring-security that referenced this issue Jul 7, 2022
sjohnr added a commit that referenced this issue Jul 7, 2022
sjohnr added a commit that referenced this issue Jul 7, 2022
@trevormarshall
Copy link
Member

No I don't believe we do @sjohnr. Let me know when you want me to enable for your directory (or feel free to enable yourselves, if a team member has shell access on the server)

@sjohnr
Copy link
Member Author

sjohnr commented Jul 11, 2022

@trevormarshall Please go ahead now. I'll be available to verify once it's taken effect.

@trevormarshall
Copy link
Member

@sjohnr done. It will be ready to verify in 20 minutes.

@sjohnr
Copy link
Member Author

sjohnr commented Jul 11, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: task A general task
Projects
Archived in project
Development

No branches or pull requests

3 participants