-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StrictHttpFirewall incorrectly rejects valid CJKV characters #11264
Comments
Almost LGTM. We also checked the behavior. |
@tawAsh1 Thank you for your feedback. User's can always invoke getEncodedUrlBlocklist and getDecodedUrlBlocklist which allow adding and removing characters from it. The allow methods are for convenience for URL values that we felt were more likely to want to be enabled. I did not consider newlines to be likely for users to want to add/remove. However, since you requested the convenience methods, I went ahead and added them in e2eed33 Please let me know if this looks good to you. |
LGTM! Thanks. |
No description provided.
The text was updated successfully, but these errors were encountered: