Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update saganCreateRelease task property referenceDocUrl #11016

Closed
marcusdacoregio opened this issue Mar 22, 2022 · 3 comments
Closed

Update saganCreateRelease task property referenceDocUrl #11016

marcusdacoregio opened this issue Mar 22, 2022 · 3 comments
Assignees
Labels
in: build An issue in the build type: bug A general bug
Milestone

Comments

@marcusdacoregio
Copy link
Contributor

Currently, the referenceDocUrl is using https://docs.spring.io/spring-security/site/docs/{version}/reference/html5/ as the URL, this is an old URL and gives a 404 for the new docs deployment.

The task should use https://docs.spring.io/spring-security/reference/{version}/index.html as the new URL for the version 5.6.x onwards.

@marcusdacoregio marcusdacoregio added in: build An issue in the build type: task A general task labels Mar 22, 2022
@marcusdacoregio marcusdacoregio self-assigned this Mar 22, 2022
@marcusdacoregio marcusdacoregio added type: bug A general bug and removed type: task A general task labels Mar 22, 2022
@Enkosz
Copy link
Contributor

Enkosz commented Mar 22, 2022

Hi @marcusdacoregio! I can handle it to take some work off from you guys and somehow help the team, in which version is planned?

@marcusdacoregio
Copy link
Contributor Author

Hi @Enkosz, I appreciate your disponibility. You can work on it, just make sure that the base branch is 5.7.x instead of main when you open the PR.

You can comment here if you need any help. Thank you.

@Enkosz
Copy link
Contributor

Enkosz commented Mar 25, 2022

@marcusdacoregio I've made a PR(#11031) and thank you!

Enkosz added a commit to Enkosz/spring-security that referenced this issue Apr 1, 2022
- Updated saganCreateRelease task with the new referenceDocUrl for reference documentation

Closes spring-projectsgh-11016
marcusdacoregio pushed a commit that referenced this issue Apr 1, 2022
- Updated saganCreateRelease task with the new referenceDocUrl for reference documentation

Closes gh-11016
marcusdacoregio pushed a commit that referenced this issue Apr 1, 2022
- Updated saganCreateRelease task with the new referenceDocUrl for reference documentation

Closes gh-11016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants