Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin example for SecuritySocketAcceptorInterceptor of RSocket #10932

Closed
talerngpong opened this issue Mar 3, 2022 · 2 comments
Closed
Assignees
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Milestone

Comments

@talerngpong
Copy link
Contributor

Describe the bug
An example of Adding SecuritySocketAcceptorInterceptor bullet comes with only Java example under RSocket Security.

To Reproduce

  1. Browse to Adding SecuritySocketAcceptorInterceptor bullet.
  2. Visually compare the bullet with the previous one Minimal RSocket Security Configuration.
  3. A coding block of Adding SecuritySocketAcceptorInterceptor comes with one Java example while a coding block of Minimal RSocket Security Configuration comes with both of Java and Kotlin examples.

Expected behavior
A coding block of Adding SecuritySocketAcceptorInterceptor should come with both of Java and Kotlin examples.

Sample

// current example
@Bean
RSocketServerCustomizer springSecurityRSocketSecurity(SecuritySocketAcceptorInterceptor interceptor) {
    return (server) -> server.interceptors((registry) -> registry.forSocketAcceptor(interceptor));
}
// purposed example to be added
@Bean
fun springSecurityRSocketSecurity(interceptor: SecuritySocketAcceptorInterceptor): RSocketServerCustomizer {
    return RSocketServerCustomizer { server ->
        server.interceptors { registry ->
            registry.forSocketAcceptor(interceptor)
        }
    }
}
@talerngpong talerngpong added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Mar 3, 2022
@sjohnr sjohnr added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Mar 9, 2022
@eleftherias eleftherias changed the title Add Kotlin example for SecuritySocketAcceptorInterceptor of RSocket (documentation) Add Kotlin example for SecuritySocketAcceptorInterceptor of RSocket Mar 9, 2022
@eleftherias
Copy link
Contributor

Thank you for submitting this issue @talerngpong! I will review the associated PR #10936 today.

@eleftherias
Copy link
Contributor

Closed via bc2bb8c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants