Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelyingPartyRegistrations should read all entities #10782

Closed
Tracked by #10551
jzheaux opened this issue Jan 25, 2022 · 0 comments
Closed
Tracked by #10551

RelyingPartyRegistrations should read all entities #10782

jzheaux opened this issue Jan 25, 2022 · 0 comments
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jan 25, 2022

In a federated setup, a single metadata endpoint may have multiple IDP entities described.

It would be nice to have additional methods in RelyingPartyRegistrations to support this. For example:

Iterable<RelyingPartyRegistration.Builder> fromEntitiesDescriptorLocation(String entitiesDescriptorLocation);

Iterable<RelyingPartyRegistration.Builder> fromEntitiesDescriptor(InputSource entitiesDescriptor);

It should return a list of builders since each one represents a single IDPSSODescriptor. It will also give an opportunity to locally override settings like the registrationId.

@OrangeDog based on this comment, I'm wondering if fromEntitiesDescriptorLocation should take a public key for verifying the EntityDescriptors signature.

@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Jan 25, 2022
@jzheaux jzheaux added this to the 5.7.x milestone Jan 25, 2022
@jzheaux jzheaux self-assigned this Jan 27, 2022
jzheaux added a commit to jzheaux/spring-security that referenced this issue Jan 31, 2022
jzheaux added a commit that referenced this issue Jan 31, 2022
@jzheaux jzheaux modified the milestones: 5.7.x, 5.7.0-M2 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant