Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-tenancy Documentation - com.nimbusds.jwt.proc.JWTProcessor does not have a setJWTClaimSetJWSKeySelector method #10504

Closed
jmax01 opened this issue Nov 15, 2021 · 2 comments
Closed

Multi-tenancy Documentation - com.nimbusds.jwt.proc.JWTProcessor does not have a setJWTClaimSetJWSKeySelector method #10504

jmax01 opened this issue Nov 15, 2021 · 2 comments
Assignees
@jzheaux
Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug

Comments

@jmax01
Copy link
Contributor

jmax01 commented Nov 15, 2021

In line 326 of docs/modules/ROOT/pages/servlet/oauth2/resource-server/multitenancy.adoc#L326 there is a reference to a com.nimbusds.jwt.proc.JWTProcessor method called setJWTClaimSetJWSKeySelector.

There is no such method on com.nimbusds.jwt.proc.JWTProcessor there is a setJWTClaimsSetAwareJWSKeySelector method however.

image

To Reproduce
Read the doc

Expected behavior
Replace with the correct call.
@jmax01 jmax01 added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Nov 15, 2021
@sjohnr sjohnr added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 15, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Nov 15, 2021

Thanks, @jmax01! Are you able to submit a PR with the correction?

@jmax01
Copy link
Contributor Author

jmax01 commented Nov 15, 2021

@jzheaux I can if setJWTClaimsSetAwareJWSKeySelector is the correct method?

jmax01 added a commit to jmax01/spring-security that referenced this issue Nov 15, 2021
@jmax01
spring-projects#10504 Replace setJWTClaimSetJWSKeySelector
314a545 
Replace setJWTClaimSetJWSKeySelector  with setJWTClaimsSetAwareJWSKeySelector
@jmax01 jmax01 mentioned this issue Nov 15, 2021
Closed
jzheaux pushed a commit that referenced this issue Nov 16, 2021
@jmax01 @jzheaux
Fix setJWTClaimSetJWSKeySelector Typo
b7cc667 
Closes gh-10504
jzheaux pushed a commit that referenced this issue Nov 16, 2021
@jmax01 @jzheaux
Fix setJWTClaimSetJWSKeySelector Typo
32d79f3 
Closes gh-10504
jzheaux added a commit that referenced this issue Nov 16, 2021
@jzheaux
Fix setJWTClaimSetJWSKeySelector Typo
b7a12e1 
Closes gh-10504
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Nov 16, 2021
Closed
jzheaux added a commit that referenced this issue Nov 16, 2021
@jzheaux
Fix setJWTClaimSetJWSKeySelector Typo
ef23337 
Closes gh-10504
Closed
jzheaux added a commit that referenced this issue Nov 16, 2021
@jzheaux
Fix setJWTClaimSetJWSKeySelector Typo
6fcee07 
Closes gh-10504
Closed
jzheaux added a commit that referenced this issue Nov 16, 2021
@jzheaux
Fix setJWTClaimSetJWSKeySelector Typo
ff7f8f9 
Closes gh-10504
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jmax01 @jzheaux @sjohnr @spring-projects-issues