Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Documentation for Static Methods Classes for mockJwt() and jwt() #10254

Closed
miller79 opened this issue Sep 13, 2021 · 4 comments · Fixed by #10255
Closed

Add Documentation for Static Methods Classes for mockJwt() and jwt() #10254

miller79 opened this issue Sep 13, 2021 · 4 comments · Fixed by #10255
Assignees
@miller79 @marcusdacoregio
Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement

Comments

@miller79
Copy link
Contributor

I'm looking through the documentation for testing Spring Security with WebFlux and it shows a static method being used mockJwt() and jwt() but it doesn't have any references to what class that comes from. The method appears to be in org.springframework.security.test.web.reactive.server.SecurityMockServerConfigurers.java but I feel the documentation should reflect this so users do not have to go searching for this when their IDE is unable to autocomplete the class.
@miller79 miller79 added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Sep 13, 2021
@miller79 miller79 changed the title Add Documentation for Static Methods Classes for mockJwt() and jwt() Add Documentation for Static Methods Classes for mockJwt() and jwt() Sep 13, 2021
@marcusdacoregio marcusdacoregio self-assigned this Sep 13, 2021
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 13, 2021
@marcusdacoregio
Copy link
Contributor

Hi @miller79, thanks for reaching out.

Are you able to submit a PR to address this issue?

@miller79
Copy link
Contributor Author

I should be able to just got to get a little time. I'll see if I can throw something out there today sometime.

@marcusdacoregio
Copy link
Contributor

Ok @miller79, the issue is yours now.

Take your time to do that, and, if you aren't able to submit a PR, please let me know so I can do that.

@miller79
Copy link
Contributor Author

@marcusdacoregio I have created this PR and fixed a few other issues I saw on the way.

#10255

Not sure I have the ability to link the issue with the PR.

@miller79 miller79 mentioned this issue Sep 13, 2021
Merged
marcusdacoregio pushed a commit that referenced this issue Sep 14, 2021
@miller79 @marcusdacoregio
Updated test.adoc SecurityMockServerConfigurers method references
1653b78 
Updated all references to SecurityMockServerConfigurers to refer to
correct methods.
Added documentation for mockJwt to include the
SecurityMockServerConfigurers class.

Issue gh-10254
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.5.x labels Sep 14, 2021
Closed
marcusdacoregio pushed a commit that referenced this issue Sep 14, 2021
@miller79 @marcusdacoregio
Updated test.adoc SecurityMockServerConfigurers method references
7614346 
Updated all references to SecurityMockServerConfigurers to refer to
correct methods.
Added documentation for mockJwt to include the
SecurityMockServerConfigurers class.

Issue gh-10254
Closed
marcusdacoregio pushed a commit that referenced this issue Sep 14, 2021
@miller79 @marcusdacoregio
Updated test.adoc SecurityMockServerConfigurers method references
1ca04ff 
Updated all references to SecurityMockServerConfigurers to refer to
correct methods.
Added documentation for mockJwt to include the
SecurityMockServerConfigurers class.

Issue gh-10254
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miller79 miller79

@marcusdacoregio marcusdacoregio

Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated the Reactive Test Support Documentation references for SecurityMockServerConfigurers
3 participants
@miller79 @marcusdacoregio @spring-projects-issues