Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce samplesBranch property #10019

Closed
marcusdacoregio opened this issue Jun 29, 2021 · 0 comments
Closed

Introduce samplesBranch property #10019

marcusdacoregio opened this issue Jun 29, 2021 · 0 comments
Assignees
@marcusdacoregio
Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.6.0-M1

Comments

@marcusdacoregio
Copy link
Contributor

Related #9986

Context
For each version of Spring Security to be able to point to the right Spring Security Samples branch, we should introduce a new property in gradle.properties called samplesBranch. This property then would be used in our links computing to prevent broken links.
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples type: enhancement A general enhancement labels Jun 29, 2021
@marcusdacoregio marcusdacoregio added this to the 5.6.0-M1 milestone Jun 29, 2021
@marcusdacoregio marcusdacoregio self-assigned this Jun 29, 2021
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jun 29, 2021
@marcusdacoregio
Add samplesBranch property
8f1587d 
Closes spring-projectsgh-10019
@marcusdacoregio marcusdacoregio mentioned this issue Jun 29, 2021
Closed
marcusdacoregio added a commit that referenced this issue Jul 1, 2021
@marcusdacoregio
Add samplesBranch property
51dfae1 
Closes gh-10019
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Jul 1, 2021
Closed
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@marcusdacoregio
Add samplesBranch property
55a3035 
Closes spring-projectsgh-10019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.6.0-M1
Development

No branches or pull requests
2 participants
@marcusdacoregio @spring-projects-issues