Polish Tests

Issue gh-11657
spring-projects · Aug 3, 2022 · aa22594 · aa22594
1 parent 07ea139
commit aa22594
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/...framework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurerTests.java b/...framework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurerTests.java
@@ -82,6 +82,7 @@
 import org.springframework.security.saml2.provider.service.authentication.Saml2AuthenticationToken;
 import org.springframework.security.saml2.provider.service.authentication.TestOpenSamlObjects;
 import org.springframework.security.saml2.provider.service.authentication.TestSaml2AuthenticationRequestContexts;
+import org.springframework.security.saml2.provider.service.registration.InMemoryRelyingPartyRegistrationRepository;
 import org.springframework.security.saml2.provider.service.registration.RelyingPartyRegistration;
 import org.springframework.security.saml2.provider.service.registration.RelyingPartyRegistrationRepository;
 import org.springframework.security.saml2.provider.service.registration.TestRelyingPartyRegistrations;
@@ -113,10 +114,10 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
 import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.BDDMockito.given;
 import static org.mockito.Mockito.atLeastOnce;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoInteractions;
@@ -429,6 +430,8 @@ private Saml2WebSsoAuthenticationFilter getSaml2SsoFilter(FilterChainProxy chain
 
 	private void performSaml2Login(String expected) throws IOException, ServletException {
 		// setup authentication parameters
+		this.request.setRequestURI("/login/saml2/sso/registration-id");
+		this.request.setServletPath("/login/saml2/sso/registration-id");
 		this.request.setParameter("SAMLResponse",
 				Base64.getEncoder().encodeToString("saml2-xml-response-object".getBytes()));
 		// perform test
@@ -821,9 +824,7 @@ RelyingPartyRegistrationRepository relyingPartyRegistrationRepository() {
 					.assertingPartyDetails((party) -> party.verificationX509Credentials(
 							(c) -> c.add(TestSaml2X509Credentials.relyingPartyVerifyingCredential())))
 					.build();
-			RelyingPartyRegistrationRepository repository = mock(RelyingPartyRegistrationRepository.class);
-			given(repository.findByRegistrationId(anyString())).willReturn(registration);
-			return repository;
+			return spy(new InMemoryRelyingPartyRegistrationRepository(registration));
 		}
 
 	}