-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the number of max attempts to the retry context for all policies #395
Labels
Milestone
Comments
e-ivaldi
added a commit
to e-ivaldi/spring-retry
that referenced
this issue
Oct 31, 2023
…hat have a maximum number of attempts set
@garyrussell i saw you were involved in the discussion, i'm just not familiar with the process here, how can we get the pr reviewed? |
Someone just has to pick it up; I have been out sick the last couple of weeks; as such, I have a huge backlog so I may not get to this for a while. |
e-ivaldi
added a commit
to e-ivaldi/spring-retry
that referenced
this issue
Nov 17, 2023
…that already had an author list
e-ivaldi
added a commit
to e-ivaldi/spring-retry
that referenced
this issue
Nov 17, 2023
…t already had an author list
e-ivaldi
added a commit
to e-ivaldi/spring-retry
that referenced
this issue
Nov 17, 2023
…hat have a maximum number of attempts set
e-ivaldi
added a commit
to e-ivaldi/spring-retry
that referenced
this issue
Nov 17, 2023
…t already had an author list
e-ivaldi
added a commit
to e-ivaldi/spring-retry
that referenced
this issue
Nov 17, 2023
…hat have a maximum number of attempts set
e-ivaldi
added a commit
to e-ivaldi/spring-retry
that referenced
this issue
Nov 17, 2023
…t already had an author list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is sometimes useful to be aware, within a retry context, whether the current attempt is the last attempt when using a 'maximum number of attempts before failure' type of retry policy.
Following up on this discussion I am opening a small PR to add that type of support to spring-retry.
In order to achieve the desired result, for all policies, a new attribute is going to be added to the context named "context.max-attempts" that will contain the number of max attempts set in the policy, if any, or -1 otherwise.
The PR won't provide extra support to read and parse the attribute value via ad-hoc methods added to the retry contexts themselves.
PR link: #396
The text was updated successfully, but these errors were encountered: