-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use non-shaded client with AuthenticationToken
#562
Comments
Thanks for the report @austek , While the ObjectMapperFactory is not shaded, it does indeed look like the returned ObjectMapper is in fact a shaded variant. |
@austek we do recommend using the shaded pulsar client w/ Spring Boot as the Pulsar client uses earlier versions of 3rd party libs that are also used by Spring Boot. You may run into classpath version mismatches. Regardless, I am going to submit a fix for this issue. |
This commit removes the use of the Pulsar ObjectMapperFactory when converting the authentication config props map to a JSON string. The Pulsar factory operates on a shaded returned value of Jackson ObjectMapper which may not exist when users are using the non-shaded version of the Pulsar client lib. See spring-projects/spring-pulsar#562
I understand the recommendation, however security scans picked up CVEs which needs to be addressed and with shaded dependencies that's not really easy |
I understand @austek , it sounds like you are using the unshaded so that you can override the vulnerable dependencies. Did you file an issue w/ Pulsar on the affected libs? If not, please let me know which ones in particular and I will file an issue and get a fix into Pulsar. Thanks |
This commit removes the use of the Pulsar ObjectMapperFactory when converting the authentication config props map to a JSON string. The Pulsar factory operates on a shaded returned value of Jackson ObjectMapper which may not exist when users are using the non-shaded version of the Pulsar client lib. See spring-projects/spring-pulsar#562 See gh-39389
@austek the fix has been merged into Spring Boot 3.2.x branch and will be available in Spring Boot 3.2.3 on 2024-11-22. |
When using the non-shaded pulsar client enabling
AuthenticationToken
causesA sample project with the problem
The text was updated successfully, but these errors were encountered: