Use WebJars versioned URLs #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to improve efficiency (see spring-projects/spring-framework#27619) and allow native image compatibility, this commit uses WebJars versioned URLs which are supported out of the box on Spring Boot via /META-INF/resources default resource location configuration, removing the need to use webjars-locator-core dependency and WebJarsResourceResolver. I have been able to measure a consistent 5% startup time improvement on the JVM with that simple change on my local machine.
sdeleuze
added a commit
to sdeleuze/spring-petclinic
that referenced
this pull request
Oct 16, 2022
- Tested with mysql - Rebased on top of spring-projects#1099 for WebJars support - Switch to Caffeine for caching since it is supported on native unlike Ehcache - Use -H:+AddAllCharsets -H:+IncludeAllTimeZones flags required for MySQL - Use latest metadata repository 0.2.3 (will be the default with Native Build Tools 0.9.15) - Registers resource hints for WebJars and db resource directory
fgibelin
added a commit
to cloudbees-guru/spring-petclinic
that referenced
this pull request
Oct 24, 2022
Use WebJars versioned URLs (spring-projects#1099)
sdeleuze
added a commit
to sdeleuze/spring-petclinic-kotlin
that referenced
this pull request
Apr 5, 2023
In order to improve efficiency (see spring-projects/spring-framework#27619) and allow native image compatibility, this commit uses WebJars versioned URLs which are supported out of the box on Spring Boot via /META-INF/resources default resource location configuration, removing the need to use webjars-locator-core dependency and WebJarsResourceResolver. I have been able to measure a consistent 5% startup time improvement on the JVM with that simple change on my local machine. Similar to spring-projects/spring-petclinic#1099
sdeleuze
added a commit
to sdeleuze/spring-petclinic-kotlin
that referenced
this pull request
Apr 6, 2023
In order to improve efficiency (see spring-projects/spring-framework#27619) and allow native image compatibility, this commit uses WebJars versioned URLs which are supported out of the box on Spring Boot via /META-INF/resources default resource location configuration, removing the need to use webjars-locator-core dependency and WebJarsResourceResolver. I have been able to measure a consistent 5% startup time improvement on the JVM with that simple change on my local machine. Similar to spring-projects/spring-petclinic#1099
mahajokhio2
pushed a commit
to mahajokhio2/spring-petclinic
that referenced
this pull request
Jun 2, 2024
In order to improve efficiency (see spring-projects/spring-framework#27619) and allow native image compatibility, this commit uses WebJars versioned URLs which are supported out of the box on Spring Boot via /META-INF/resources default resource location configuration, removing the need to use webjars-locator-core dependency and WebJarsResourceResolver. I have been able to measure a consistent 5% startup time improvement on the JVM with that simple change on my local machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve efficiency (see spring-projects/spring-framework#27619) and allow native image compatibility, this commit uses WebJars versioned URLs which are supported out of the box on Spring Boot via
/META-INF/resourcesdefault resource location configuration, removing the need to usewebjars-locator-coredependency andWebJarsResourceResolver.I have been able to measure a consistent 5% startup time improvement on the JVM with that simple change on my local machine.