-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-644: documenter clean #680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty decent to me already. A couple of general comments:
- Would you mind adding Javadoc to the public methods of the newly introduced
Options
type? - Switch to
var
for the variables created in test cases for consistency
Regarding the “wipe once approach”: IIRC, we discussed this with Cora at some point. I don't remember the exact details anymore but wonder whether we can keep a variable within the Documenter
instance whether an initial wiping has occurred. As the write…
methods all return this
we could flip the flag for the first method invoked. clearOutputFolder()
looks like a good place to implement such logic. I guess we'd need to document this behavior clearly in Options.defaults()
's Javadoc.
Thanks for the feedback! Sure, no problem - I will add Javadoc and make use of |
Do you have a rough estimate when you would get to this? I'd love to get the changes into the release next Friday. I am happy to take it from here but don't want to break your flow if you're still considering it. |
7ca3af7
to
a1a9664
Compare
Hi! Thanks! |
No worries at all! Thanks for the contribution so far! |
That's polished and merged against GH-644, thanks! |
writeDocumentation
cleans the output directory before writing any documentation files per default.I think for the other public
writeXYZ
method, clearing the directory does not make any sense sincewriteModulesAsPlantUml
,writeIndividualModulesAsPlantUml
andwriteModuleCanvases
are called fromwriteDocumentation
- additional cleans in those methods would delete previously created files.@odrotbohm your feedback would be appreciated! :)
Thanks!