Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve internal API for event externalization #353

Closed
odrotbohm opened this issue Nov 1, 2023 · 0 comments
Closed

Improve internal API for event externalization #353

odrotbohm opened this issue Nov 1, 2023 · 0 comments
Assignees
@odrotbohm
Labels
in: event publication registry Event publication registry type: improvement Minor improvements
Milestone
1.1 RC2

Comments

@odrotbohm
Copy link
Member

We should rather return a CompletableFuture from the final externalize(…) call so that we can hand this out from the listener to make sure that any message brokers using asynchronous message publication. This would also allow us to conclude the event externalization by publishing an application event in turn, to both carry the externalization result forward (if provided by the broker) and as a testing target using the Scenario.
@odrotbohm odrotbohm added the in: event publication registry Event publication registry label Nov 1, 2023
@odrotbohm odrotbohm added this to the 1.1 RC2 milestone Nov 1, 2023
@odrotbohm odrotbohm self-assigned this Nov 1, 2023
odrotbohm added a commit that referenced this issue Nov 1, 2023
@odrotbohm
GH-353 - Improvements in internal event externalization APIs.
ca32c29 
DelegatingEventExternalizer.externalize(…) flavors now return a CompletableFuture to allow the target APIs to use asynchronous message sending and to transparently return a result from those invocations.
odrotbohm added a commit that referenced this issue Nov 1, 2023
@odrotbohm
GH-353 - Improvements in internal event externalization APIs.
7974285 
DelegatingEventExternalizer.externalize(…) flavors now return a CompletableFuture to allow the target APIs to use asynchronous message sending and to transparently return a result from those invocations.
odrotbohm added a commit that referenced this issue Nov 1, 2023
@odrotbohm
GH-353 - Improvements in internal event externalization APIs.
2b4419f 
DelegatingEventExternalizer.externalize(…) flavors now return a CompletableFuture to allow the target APIs to use asynchronous message sending and to transparently return a result from those invocations.
odrotbohm added a commit that referenced this issue Nov 1, 2023
@odrotbohm
GH-353 - Improvements in internal event externalization APIs.
0ae19fb 
DelegatingEventExternalizer.externalize(…) flavors now return a CompletableFuture to allow the target APIs to use asynchronous message sending and to transparently return a result from those invocations.
@odrotbohm odrotbohm added the type: improvement Minor improvements label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: event publication registry Event publication registry type: improvement Minor improvements
Projects
None yet
Milestone
1.1 RC2
Development

No branches or pull requests
1 participant
@odrotbohm