Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4 requires Jakarta EE 9 #639

Closed
wilkinsona opened this issue Apr 28, 2022 · 3 comments
Closed

2.4 requires Jakarta EE 9 #639

wilkinsona opened this issue Apr 28, 2022 · 3 comments
Assignees
Labels
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Apr 28, 2022

This was originally reported as a Spring Boot issue. It looks like the problem was introduced in this commit which accidentally upgraded a number of Jakarta EE dependencies to their EE 9 versions.

Looking at the code, I couldn't find any direct usage of the EE 9 dependencies, other than one in buildSrc:

$  find . -name "*.java" | xargs grep "import jakarta"
./buildSrc/src/test/resources/samples/integrationtest/withpropdeps/src/integration-test/java/sample/TheTest.java:import jakarta.servlet.http.HttpServletRequest;

In addition to correcting the version numbers, perhaps some dependencies could be removed altogether?

@cmuchinsky
Copy link

I believe there is one here as well:

core/src/main/java/org/springframework/ldap/support/LdapEncoder.java:import jakarta.xml.bind.DatatypeConverter

@wilkinsona
Copy link
Member Author

wilkinsona commented Apr 28, 2022

That's true for the main branch but not, AFAICT, for 2.4.x and main should be using EE 9 dependencies.

jzheaux added a commit that referenced this issue May 4, 2022
jzheaux added a commit that referenced this issue May 4, 2022
@jzheaux
Copy link
Contributor

jzheaux commented May 4, 2022

Closed in 43c57ad

@jzheaux jzheaux closed this as completed May 4, 2022
@jzheaux jzheaux self-assigned this May 4, 2022
@jzheaux jzheaux added in: build type: dependency-upgrade A dependency upgrade type: bug A general bug and removed type: dependency-upgrade A dependency upgrade labels May 4, 2022
@jzheaux jzheaux added this to the 2.4.0 milestone May 4, 2022
jzheaux added a commit that referenced this issue May 4, 2022
jzheaux added a commit that referenced this issue May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants