fix: re-new connection in PostgresChannelMessageTableSubscriber #9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshiste
force-pushed
the
fix/postgres-listen-failover
branch
from
78bc2df to
3221eeb
Compare
artembilan
requested changes
Apr 1, 2024
...java/org/springframework/integration/jdbc/channel/PostgresChannelMessageTableSubscriber.java
Outdated
Show resolved
Hide resolved
joshiste
force-pushed
the
fix/postgres-listen-failover
branch
from
3221eeb to
d0e7f7c
Compare
I've added a test that verifies for reconnection after certain time without notifications |
artembilan
requested changes
Apr 1, 2024
...org/springframework/integration/jdbc/channel/PostgresChannelMessageTableSubscriberTests.java
Show resolved
Hide resolved
...org/springframework/integration/jdbc/channel/PostgresChannelMessageTableSubscriberTests.java
Show resolved
Hide resolved
...java/org/springframework/integration/jdbc/channel/PostgresChannelMessageTableSubscriber.java
Show resolved
Hide resolved
joshiste
force-pushed
the
fix/postgres-listen-failover
branch
2 times, most recently
from
e6cc266 to
4b3e74c
Compare
artembilan
requested changes
Apr 1, 2024
|
I saw that. It does work on my machine. Is there any way to get more context (e.g. the assertion message) for this failure? |
PostgresChannelMessageTableSubscriber never renews the connection. This causes problems on DB failover. With this change the connection is renewed when notifications are not received for a certain time. fixes spring-projects#9061
joshiste
force-pushed
the
fix/postgres-listen-failover
branch
from
4b3e74c to
e30bebd
Compare
|
... and cherry-picked to Thank you for contribution; looking forward for more! |
|
What is the schedule for the next release? Is it 16th of April? https://calendar.spring.io |
|
April, 16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgresChannelMessageTableSubscriber currently never renews the connection. This causes problems on DB failover. With this change the connection is renewed when notifications are not received for a certain time.
fixes #9061