Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java DSL docs into TCP/IP chapter #3477

Closed
artembilan opened this issue Jan 26, 2021 · 0 comments · Fixed by #3479
Closed

Add Java DSL docs into TCP/IP chapter #3477

artembilan opened this issue Jan 26, 2021 · 0 comments · Fixed by #3479
Assignees
@garyrussell
Labels
type: documentation type: enhancement
Milestone
5.5 M2

Comments

@artembilan
Copy link
Member

Expected Behavior

It would be great to mention Java DSL for TCP channel adapters in the docs.
Plus Tcp.*Server/Client() factories description.

Current Behavior

Currently we have Java & Annotations configuration in the docs: https://docs.spring.io/spring-integration/docs/current/reference/html/ip.html#ip-annotation.

Context

Without knowing Tcp Java DSL factory it is hard to guess them from the docs.
Looks like we have something for UDP channel adapters:
https://docs.spring.io/spring-integration/docs/current/reference/html/ip.html#outbound-udp-adapters-java-dsl-configuration
https://docs.spring.io/spring-integration/docs/current/reference/html/ip.html#inbound-udp-adapters-java-dsl-configuration
but nothing for TCP.
@artembilan artembilan added type: enhancement status: waiting-for-triage The issue need to be evaluated and its future decided labels Jan 26, 2021
@garyrussell garyrussell added backport 5.4.x and removed status: waiting-for-triage The issue need to be evaluated and its future decided labels Jan 26, 2021
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Jan 26, 2021
@garyrussell
spring-projectsGH-3477: Add DSL Docs for TCP Components
e4685e3 
Resolves spring-projects#3477

**cherry-pick to 5.4.x**
@garyrussell garyrussell mentioned this issue Jan 26, 2021
Merged
artembilan pushed a commit that referenced this issue Jan 26, 2021
@garyrussell @artembilan
GH-3477: Add DSL Docs for TCP Components
f223343 
Resolves #3477

**cherry-pick to 5.4.x**
artembilan pushed a commit that referenced this issue Jan 26, 2021
@garyrussell @artembilan
GH-3477: Add DSL Docs for TCP Components
23e277d 
Resolves #3477

**cherry-pick to 5.4.x**

(cherry picked from commit f223343)
@artembilan artembilan added this to the 5.5 M2 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
type: documentation type: enhancement
Projects
None yet
Milestone
5.5 M2
Development

Successfully merging a pull request may close this issue.

GH-3477: Add DSL Docs for TCP Components garyrussell/spring-integration
2 participants
@garyrussell @artembilan