Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AMQP Consumer-side batch creation #3172

Closed
garyrussell opened this issue Feb 6, 2020 · 0 comments · Fixed by #3173
Closed

Add support for AMQP Consumer-side batch creation #3172

garyrussell opened this issue Feb 6, 2020 · 0 comments · Fixed by #3173
Assignees
@garyrussell
Labels
in: amqp type: enhancement
Milestone
5.3 M2

Comments

@garyrussell
Copy link
Contributor

garyrussell commented Feb 6, 2020 •
edited
Loading

See spring-projects/spring-amqp#1032

Add a ChannelAwareBatchMessageListener and map List<Message> to List<?>.

In preparation for spring-attic/spring-cloud-stream-binder-rabbit#209

In order to get efficiency on the producer side we need to enable batching on the consumer side, even when the upstream producer doesn't send messages in a batch.
@garyrussell garyrussell added this to the 5.3 M2 milestone Feb 6, 2020
@garyrussell garyrussell self-assigned this Feb 6, 2020
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Feb 7, 2020
@garyrussell
Add isConsumerBatchEnabled() to listener container
4f6ae7c 
In preparation for spring-projects/spring-integration#3172

Allow the inbound endpoint to detect if its listener container is configured
to return batches.
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Feb 7, 2020
@garyrussell
Add isConsumerBatchEnabled() to listener container
127e5b4 
In preparation for spring-projects/spring-integration#3172

Allow the inbound endpoint to detect if its listener container is configured
to return batches.
@garyrussell garyrussell mentioned this issue Feb 7, 2020
Merged
artembilan pushed a commit to spring-projects/spring-amqp that referenced this issue Feb 7, 2020
@garyrussell @artembilan
Add isConsumerBatchEnabled() to listener container
667a738 
In preparation for spring-projects/spring-integration#3172

Allow the inbound endpoint to detect if its listener container is configured
to return batches.
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Feb 7, 2020
@garyrussell
spring-projectsGH-3172: Support consumer-side batching
223016b 
Resolves spring-projects#3172

When the listener container supports creating batches of consumed
messages, present the batch as the message payload - either a
`List<Message<?>>` or `List<SomePayload>`.
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Feb 7, 2020
@garyrussell
spring-projectsGH-3172: Support consumer-side batching
1ef2699 
Resolves spring-projects#3172

When the listener container supports creating batches of consumed
messages, present the batch as the message payload - either a
`List<Message<?>>` or `List<SomePayload>`.
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Feb 7, 2020
@garyrussell
spring-projectsGH-3172: Support consumer-side batching
47d803e 
Resolves spring-projects#3172

When the listener container supports creating batches of consumed
messages, present the batch as the message payload - either a
`List<Message<?>>` or `List<SomePayload>`.
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Feb 7, 2020
@garyrussell
spring-projectsGH-3172: Support consumer-side batching
f0aa7dd 
Resolves spring-projects#3172

When the listener container supports creating batches of consumed
messages, present the batch as the message payload - either a
`List<Message<?>>` or `List<SomePayload>`.
@garyrussell garyrussell mentioned this issue Feb 7, 2020
Merged
artembilan pushed a commit that referenced this issue Feb 10, 2020
@garyrussell
GH-3172: Support consumer-side batching
538cfe4 
Resolves #3172

When the listener container supports creating batches of consumed
messages, present the batch as the message payload - either a
`List<Message<?>>` or `List<SomePayload>`.

* Add 'since' to new method.
@garyrussell garyrussell mentioned this issue May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
in: amqp type: enhancement
Projects
None yet
Milestone
5.3 M2
Development

Successfully merging a pull request may close this issue.

GH-3172: Support consumer-side batching garyrussell/spring-integration
2 participants
@garyrussell @artembilan