Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a KinesisShardEndedEvent in KclMessageDrivenChannelAdapter #112

Closed
javarno opened this issue Feb 11, 2019 · 2 comments
Closed

Add a KinesisShardEndedEvent in KclMessageDrivenChannelAdapter #112

javarno opened this issue Feb 11, 2019 · 2 comments
Labels
enhancement

Comments

@javarno
Copy link
Contributor

javarno commented Feb 11, 2019

In shardEnded emit a new event (something like a KinesisShardEndedEvent)
@artembilan
Copy link
Member

We may consider including some other event types, e.g. KinesisConsumerIdleEvent.

Something similar what we have in Spring Kafka: https://docs.spring.io/spring-kafka/docs/2.2.3.RELEASE/reference/html/_reference.html#events

Of course, we may introduce them on demand...

@artembilan
Copy link
Member

Reopen since we can't add support for this type of event until we upgrade to KCL v2.
See #155 for more info.

@artembilan artembilan reopened this Oct 21, 2019
Griffin1989106 added a commit to Griffin1989106/SpringWithAWS that referenced this issue Jul 22, 2024
@Griffin1989106
GH-112: Add KinesisShardEndedEvent
40e2229 
Fixes spring-projects/spring-integration-aws#112

* Introduce an `AwsIntegrationEvent` hierarchy
* Emit a `KinesisShardEndedEvent` from the `KinesisMessageDrivenChannelAdapter`
when current `shardIterator` is returned as `null` indicating the end
of the shard
* NOTE: `KclMessageDrivenChannelAdapter` cannot emit such an event
unit upgrade to KCL v2
Griffin1989106 added a commit to Griffin1989106/SpringWithAWS that referenced this issue Jul 22, 2024
@Griffin1989106
GH-112: Add KinesisShardEndedEvent to KclMDChA
0d43938 
Fixes spring-projects/spring-integration-aws#112
guygriffin1989106 added a commit to guygriffin1989106/SpringWithAWS that referenced this issue Jul 26, 2024
@guygriffin1989106
GH-112: Add KinesisShardEndedEvent
69eba51 
Fixes spring-projects/spring-integration-aws#112

* Introduce an `AwsIntegrationEvent` hierarchy
* Emit a `KinesisShardEndedEvent` from the `KinesisMessageDrivenChannelAdapter`
when current `shardIterator` is returned as `null` indicating the end
of the shard
* NOTE: `KclMessageDrivenChannelAdapter` cannot emit such an event
unit upgrade to KCL v2
guygriffin1989106 added a commit to guygriffin1989106/SpringWithAWS that referenced this issue Jul 26, 2024
@guygriffin1989106
GH-112: Add KinesisShardEndedEvent to KclMDChA
0851de5 
Fixes spring-projects/spring-integration-aws#112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artembilan @javarno