-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VndErrors logref is not just Integer #1291
Comments
According to https://github.com/blongden/vnd.error, logref is for "expressing a (numeric/alpha/alphanumeric) identifier". This patches `VndError` to support both strings and integers, ensuring each serializes properly. NOTE: `VndErrors` has been deprecated due to the spec itself being dead since 2014. However, it must be supported until fully removed from Spring HATEOAS.
According to https://github.com/blongden/vnd.error, logref is for "expressing a (numeric/alpha/alphanumeric) identifier". This patches `VndError` to support both strings and integers, ensuring each serializes properly. NOTE: `VndErrors` has been deprecated due to the spec itself being dead since 2014. However, it must be supported until fully removed from Spring HATEOAS.
@odrotbohm @jvalkeal I've coded a patch against |
After investigating this a bit more in detail, it looks like the change made for #775 caused the constructor argument incompatibly change from |
According to https://github.com/blongden/vnd.error, logref is for "expressing a (numeric/alpha/alphanumeric) identifier". This patches `VndError` to support both strings and integers, ensuring each serializes properly. NOTE: `VndErrors` has been deprecated due to the spec itself being dead since 2014. However, it must be supported until fully removed from Spring HATEOAS. Original pull request: #1293.
According to https://github.com/blongden/vnd.error, logref is for "expressing a (numeric/alpha/alphanumeric) identifier". This patches `VndError` to support both strings and integers, ensuring each serializes properly. NOTE: `VndErrors` has been deprecated due to the spec itself being dead since 2014. However, it must be supported until fully removed from Spring HATEOAS. Backport of: #1291. Original pull request: #1293.
Looks like constructor is trying to parse
Integer
out fromString
:spring-hateoas/src/main/java/org/springframework/hateoas/mediatype/vnderrors/VndErrors.java
Line 95 in 5d1136e
This then for example in a dataflow errors out when trying to upgrade to boot 2.3.x:
At least https://github.com/blongden/vnd.error mentions
logref
beingnumeric/alpha/alphanumeric
The text was updated successfully, but these errors were encountered: