Flatten nested argument maps in QuerydslDataFetcher
#1085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now flatten argument maps to ensure keys in the resulting parameter map are fully-qualified property paths. Previously, we built a parameter map containing nested maps leading to invalid queries.
Refine assertions to ignore locale-specific error messages.
rstoyanchev
pushed a commit
that referenced
this pull request
Dec 4, 2024
Refine assertions to ignore locale-specific error messages. See gh-1085
rstoyanchev
added a commit
that referenced
this pull request
Dec 4, 2024
Use single MultiValueMap in method that flattens arguments vs creating a new one at each level of recursion. See gh-1085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now flatten argument maps to ensure keys in the resulting parameter map are fully-qualified property paths.
Previously, we built a parameter map containing nested maps leading to invalid queries.
Closes gh-1081