Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AOT: No JSON Encoder error using GraphlQL client #837

Closed
github-actions bot opened this issue Oct 13, 2023 · 1 comment
Closed

AOT: No JSON Encoder error using GraphlQL client #837

github-actions bot opened this issue Oct 13, 2023 · 1 comment
Assignees
@bclozel
Labels
in: core Issues related to config and core support type: backport type: bug A general bug

Comments

@github-actions
Copy link
Contributor

Backport of gh-825
@github-actions github-actions bot added in: core Issues related to config and core support type: backport type: bug A general bug labels Oct 13, 2023
@github-actions github-actions bot added this to the 1.1.8 milestone Oct 13, 2023
@bclozel bclozel self-assigned this Oct 13, 2023
bclozel added a commit that referenced this issue Oct 13, 2023
@bclozel
Fix GraalVM reflection metadata for GraphQL client
cb2f4b2 
Prior to this commit, the embedded reachability metadata for GraalVM
would declare a reflection hint for `GraphQlWebSocketMessage` when the
RSocket or WebSocket clients are reachable.
The `CodecDelegate` relies on this message class to test codecs and
detect a JSON-capable instance. This is true for all supported
GraphQlClient implementations.

This commit revisits the embedded reachability metadata to:

* allow reflection on `GraphQlWebSocketMessage` if any client extending
  `AbstractGraphQlClientBuilder` is available
* allow reflection on `GraphQlWebSocketMessage` if a
  `GraphQlWebSocketHandler` is reachable

Fixes gh-837
@github-actions
Copy link
Contributor Author

Fixed via cb2f4b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: core Issues related to config and core support type: backport type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bclozel