Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce BeanDefinition cloning from isFactoryBean #820

Closed
wants to merge 1 commit into from
Closed

Reduce BeanDefinition cloning from isFactoryBean #820

wants to merge 1 commit into from

Conversation

philwebb
Copy link
Member

Update AbstractBeanFactory.isFactoryBean to only create the merged local
bean definition when absolutely necessary.

@philwebb
Reduce BeanDefinition cloning from isFactoryBean
7c12b68 
Update AbstractBeanFactory.isFactoryBean to only create the merged local
bean definition when absolutely necessary.

Issue: SPR-12236
@spring-projects-issues spring-projects-issues mentioned this pull request Jan 11, 2019
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 24, 2019
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Nov 11, 2021
@rstoyanchev rstoyanchev added this to the 6.0.x milestone Nov 23, 2021
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 23, 2021
@jhoeller jhoeller modified the milestones: 6.0.x, 6.1.x Feb 14, 2023
@jhoeller jhoeller modified the milestones: 6.1.x, 6.x Backlog Jun 6, 2023
@jhoeller
Copy link
Contributor

jhoeller commented Aug 3, 2023

After #23336 and #23337, this seems to be covered and not worth optimizing there anymore.

@jhoeller jhoeller closed this Aug 3, 2023
@jhoeller jhoeller removed this from the 6.x Backlog milestone Aug 3, 2023
@sbrannen sbrannen added the status: declined A suggestion or change that we don't feel we should currently apply label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@philwebb @jhoeller @sbrannen @rstoyanchev @spring-projects-issues