Use encoded resource path instead of input path validation in spring-webflux #33568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
in: web
rstoyanchev
changed the title
rstoyanchev
approved these changes
Sep 19, 2024
|
Those method are now re-used, see #33574. |
cesarhernandezgt
pushed a commit
to cesarhernandezgt/spring-framework
that referenced
this pull request
Oct 30, 2024
Closes: spring-projectsgh-33568 (cherry picked from commit 94c0482)
cesarhernandezgt
pushed a commit
to cesarhernandezgt/spring-framework
that referenced
this pull request
Nov 4, 2024
Closes: spring-projectsgh-33568 (cherry picked from commit 94c0482)
RxL-Deepak-Agrawal
pushed a commit
to RxL-Deepak-Agrawal/spring-framework
that referenced
this pull request
Nov 26, 2024
Closes: spring-projectsgh-33568 (cherry picked from commit 94c0482)
lijunyzzZ
pushed a commit
to succsoft/spring-framework
that referenced
this pull request
Dec 4, 2024
JulianSubito
added a commit
to JulianSubito/spring-framework
that referenced
this pull request
Jan 3, 2025
abhinaynagpal
added a commit
to abhinaynagpal/spring-framework
that referenced
this pull request
Jan 7, 2025
Cherry pick of : a) Use encoded resource path instead of input path validation in spring-webflux spring-projects#33568 b) Updates to resource handling for functional endpoints spring-projects#33434 This Addresses CVE-2024-38819 and CVE-2024-38816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds minor fix, to the validation introduced here: d86bf8b when resolving issue #33434
It seems that in the initial fix for spring-webmvc was created correctly, but for spring-webflux validation method was used incorrectly