Throw runtime error for @TransactionalEventListener when @Transactional propagation level is not REQUIRES_NEW or NOT_SUPPORTED
#33470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jaeyoung22 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Jaeyoung22 Thank you for signing the Contributor License Agreement! |
Jaeyoung22
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
Jaeyoung22
changed the title
jhoeller
added
type: enhancement
jhoeller
added a commit
that referenced
this pull request
Sep 27, 2024
sbrannen
changed the title
@TransactionalEventListener when @Transactional propagation level is not REQUIRES_NEW or NOT_SUPPORTED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #30679, #31414, and #31907, if a method is a
@TransactionalEventListenerwith a propagation level other than@Transactional(propagation = Propagation.REQUIRES_NEW)or@Transactional(propagation = Propagation.NOT_SUPPORTED), a runtime error will be thrown.However, there is no runtime error yet for
@Transactionalwith all propagation level on the top of the class.For classes that use
@Servicewith@Transactionalat the top and don't attach this annotation to the method where the write operation takes place, there were cases where it didn't work as intended because no runtime error was thrown.So I'd like to contribute to this.