Add tests for ControllerAdviceBean#resolveBean() and revise existing tests

[tafjwr]

Overview

I think ControllerAdviceBean#resolveBean() should be tested, because it is a public API and depends on the cache system, so I'd like to add tests for that.

Related Issues

• Document ControllerAdviceBean as internal usage #32776

[tafjwr]

Plus, I noticed that the some test method pairs perform precisely the same tests (xxxForBeanName and xxxForBeanInstance). There is no longer a ControllerAdviceBean constructor that accepts a bean instance, so xxxForBeanInstance test methods could be omitted.

spring-framework/spring-web/src/test/java/org/springframework/web/method/ControllerAdviceBeanTests.java

Lines 98 to 106 in 328b721

	@Test
	void orderedWithLowestPrecedenceByDefaultForBeanName() {
	assertOrder(SimpleControllerAdvice.class, Ordered.LOWEST_PRECEDENCE);
	}
	@Test
	void orderedWithLowestPrecedenceByDefaultForBeanInstance() {
	assertOrder(SimpleControllerAdvice.class, Ordered.LOWEST_PRECEDENCE);
	}

[sbrannen]

Plus, I noticed that the some test method pairs perform precisely the same tests (xxxForBeanName and xxxForBeanInstance). There is no longer a ControllerAdviceBean constructor that accepts a bean instance, so xxxForBeanInstance test methods could be omitted.

Good catch.

Please remove the obsolete "bean instance" tests.

[tafjwr]

Thank for your advice! I removed the obsolete tests on 8d045ad

[sbrannen]

This has been merged into main in 4ffeddb and revised in 346b6f7.

Thanks