Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleAsyncTaskScheduler stops accepting new tasks when isShutdown #33336

Closed

Conversation

genuss
Copy link
Contributor

@genuss genuss commented Aug 7, 2024

Fixes #33334

I didn't find specific tests for this call and I believe the proper ones would be too cumbersome to write. Hope you don't mind, @simonbasle

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 7, 2024
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 7, 2024
@jhoeller jhoeller added this to the 6.2.0-M7 milestone Aug 7, 2024
@jhoeller jhoeller modified the milestones: 6.2.0-M7, 6.1.12 Aug 7, 2024
@jhoeller
Copy link
Contributor

jhoeller commented Aug 7, 2024

@simonbasle actually it would be good to bring this into 6.1.12 already, rebasing the PR accordingly.

@simonbasle simonbasle changed the title Use isShutdown() instead of isTerminated() to check if an executor shouldn't accept new tasks SimpleAsyncTaskScheduler stops accepting new tasks when isShutdown Aug 7, 2024
@simonbasle simonbasle closed this in 9b85a24 Aug 7, 2024
@genuss
Copy link
Contributor Author

genuss commented Aug 7, 2024

Thanks for the fast feedback, folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleAsyncTaskScheduler should ignore scheduled exceptions after shutdown (not termination)
4 participants